-
Notifications
You must be signed in to change notification settings - Fork 70
Make basic INLA interface and simple marginalisation routine #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Make basic INLA interface and simple marginalisation routine #533
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
398979a
to
c6010f3
Compare
dad163c
to
a473e87
Compare
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Hey @Michal-Novomestsky, thanks for all your work here! I recently returned from travel so I'm just now catching up on my backlog. I assume you're asking why the Read the Docs workflow is failing? Opening the CI logs and expanding the line with the error displays the following stack trace:
Is this helpful? |
@maresb Ah yep that makes sense - this PR is dependent on two other PRs in PyMC and Pytensor respectively, so it (and the rest of the unittests) are failing because those haven't been merged yet. Thanks for the help! |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
For some reason, |
Ok, just three test cases are failing, which @zaxtax agrees shouldn't be related to the PR itself. Once these are sorted we can merge @ricardoV94 @jessegrabowski |
Addresses #532 and #344.
Relies on pymc-devs/pytensor#1582 and pymc-devs/pymc#7895.
Currently uses a closed-form solution for a specific case (nested normals) while awaiting pymc-devs/pytensor#1550