Skip to content

Addition of features to handle chromatograms #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 28, 2025

Conversation

rkjulian
Copy link
Contributor

This feature adds a new base class for spectra and chromatograms and adds a class for chromatograms that allows SRM type data to be accessed by index.

I ran tox -e py312,py313 and all the tests pass for these environments.

@auto-assign auto-assign bot requested a review from MKoesters March 18, 2025 16:30
@fu
Copy link
Member

fu commented Mar 28, 2025

Black failing :/

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
22.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@StSchulze StSchulze merged commit b0c9cf1 into dev Mar 28, 2025
4 of 5 checks passed
@StSchulze StSchulze deleted the feature/chromatogram_access branch March 28, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants