Skip to content

Update GPU docker makefile #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Update GPU docker makefile #3434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions docker/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

DOCKER_FILE=Dockerfile
BASE_IMG=ubuntu:24.04
BASE_CUDA_IMG=nvidia/cuda:12.6.3-cudnn-runtime-ubuntu24.04
DOCKER_CMD=docker
HOST_WORK_DIR=${HOME}/pyro_docker
UID=999
Expand Down Expand Up @@ -72,11 +73,11 @@ build-gpu: ##
## default - latest pyro-ppl wheel on pypi
##
${DOCKER_CMD} build -t ${IMG_NAME} \
--build-arg base_img=${BASE_IMG} \
--build-arg base_img=${BASE_CUDA_IMG} \
--build-arg uid=${UID} \
--build-arg gid=${GID} \
--build-arg ostype=${OSTYPE} \
--build-arg pytorch_whl=cu118 \
--build-arg pytorch_whl=cu126 \
--build-arg python_version=${python_version} \
--build-arg pytorch_branch=${pytorch_branch} \
--build-arg pyro_git_url=${pyro_git_url} \
Expand Down Expand Up @@ -107,7 +108,7 @@ run-gpu: ##
## cmd: command invoked on running a docker instance.
## default - bash
##
docker run --init --runtime=nvidia -it --user ${USER} \
docker run --init --gpus=all -it --user ${USER} \
-v ${HOST_WORK_DIR}:${DOCKER_WORK_DIR} \
${IMG_NAME} ${cmd}

Expand All @@ -127,7 +128,7 @@ notebook-gpu: ##
## Args:
## img: use image name given by `img`.
##
docker run --runtime=nvidia --init -it -p 8888:8888 --user ${USER} \
docker run --gpus=all --init -it -p 8888:8888 --user ${USER} \
-v ${HOST_WORK_DIR}:${DOCKER_WORK_DIR} \
${IMG_NAME}

Expand All @@ -147,7 +148,7 @@ lab-gpu: ##
## Args:
## img: use image name given by `img`.
##
docker run --runtime=nvidia --init -it -p 8888:8888 --user ${USER} \
docker run --gpus=all --init -it -p 8888:8888 --user ${USER} \
-v ${HOST_WORK_DIR}:${DOCKER_WORK_DIR} \
${IMG_NAME} jupyter lab --port=8888 --no-browser --ip=0.0.0.0

Expand Down