Skip to content

[Docs] Fix typo in docs for start and end of century #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pauln-relay
Copy link
Contributor

@pauln-relay pauln-relay commented Aug 12, 2025

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary

  • Fix typo in docs for dt.start_of('century') and dt.end_of('century') to reflect correct century bounds
  • No code change - validated the rest of the examples for modifiers ✅

Validation

>>> import pendulum
>>> dt = pendulum.datetime(2012, 1, 31, 12, 0, 0)
>>> dt.start_of('century')
DateTime(2001, 1, 1, 0, 0, 0, tzinfo=Timezone('UTC'))
>>> dt.end_of('century')
DateTime(2100, 12, 31, 23, 59, 59, 999999, tzinfo=Timezone('UTC'))

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the values I would have expected, but this has been consistent since Pendulm 1.0.2.

Copy link

codspeed-hq bot commented Aug 12, 2025

CodSpeed Performance Report

Merging #910 will not alter performance

Comparing pauln-relay:docs-fix-start-of-century (881bd7f) with master (2adcc02)

Summary

✅ 1 untouched benchmarks

@pauln-relay
Copy link
Contributor Author

Not the values I would have expected, but this has been consistent since Pendulm 1.0.2.

Same - I learned more about centuries today than I had planned

@Secrus Secrus closed this Aug 13, 2025
@Secrus Secrus reopened this Aug 13, 2025
@Secrus Secrus merged commit 8a1860d into python-pendulum:master Aug 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants