Fix crash on settable property alias

[ilevkivskyi]

Fixes #19572

Surprisingly, when working on this I found another inconsistency in how .definiton is set. So after all I decided to do some cleanup, now .definiton should always point do the Decortor if the definition is a decorated function (no matter whether it is a trivial decorator like @abstractmethod or @overload or a "real" one).

[sterliakov]

Primer output isn't obviously correct this time:

• Could you check the last line of prefect diff? Looks like self binding is missed there for some reason.
• Was the ibis note duplicated before? Or why is it gone?

[ilevkivskyi]

@sterliakov the prefect change is correct. We normally prepend self in notes about incompatible override, it was omitted here because of a decorator with ParamSpec, but now it is consistent. The ibis change is a little bug in my PR, I am testing a fix locally now.

[github-actions]

Diff from mypy_primer, showing the effect of this PR on open source code:

prefect (https://github.com/PrefectHQ/prefect)
+ src/prefect/blocks/core.py:1079: note: "load" of "Block" defined here
+ src/prefect/results.py:104: note: "get_default_result_storage" defined here
+ src/prefect/results.py:166: note: "resolve_result_storage" defined here
+ src/prefect/results.py:472: note: "_exists" of "ResultStore" defined here
+ src/prefect/results.py:551: note: "_read" of "ResultStore" defined here
+ src/prefect/results.py:745: note: "_persist_result_record" of "ResultStore" defined here
+ src/prefect/blocks/core.py:1177: note: "load_from_ref" of "Block" defined here
+ src/prefect/deployments/runner.py:992: note: "from_storage" of "RunnerDeployment" defined here
+ src/prefect/results.py:166: note: "resolve_result_storage" defined here
+ src/prefect/results.py:374: note: "update_for_flow" of "ResultStore" defined here
+ src/prefect/results.py:398: note: "update_for_task" of "ResultStore" defined here
+ src/prefect/artifacts.py:84: note: "create" of "Artifact" defined here
+ src/prefect/artifacts.py:151: note: "get" of "Artifact" defined here
+ src/prefect/artifacts.py:248: note: "format" of "Artifact" defined here
+ src/prefect/artifacts.py:334: note: "format" of "ProgressArtifact" defined here
- src/prefect/testing/fixtures.py:424: note:          def process_events(dequeue_events: bool = ..., min_events: int = ..., timeout: int = ...) -> Union[R?, Coroutine[Any, Any, R?]]
+ src/prefect/testing/fixtures.py:424: note:          def process_events(self, dequeue_events: bool = ..., min_events: int = ..., timeout: int = ...) -> Union[R?, Coroutine[Any, Any, R?]]

[sterliakov]

All good now, thanks!