-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Make IntEnum/StrEnum values passable to functions expecting literal ints or strs #19617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ambv
wants to merge
1
commit into
python:master
Choose a base branch
from
ambv:enums-and-literals
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -964,7 +964,29 @@ def visit_typeddict_type(self, left: TypedDictType) -> bool: | |||||||||||||||||||
|
||||||||||||||||||||
def visit_literal_type(self, left: LiteralType) -> bool: | ||||||||||||||||||||
if isinstance(self.right, LiteralType): | ||||||||||||||||||||
return left == self.right | ||||||||||||||||||||
if left == self.right: | ||||||||||||||||||||
return True | ||||||||||||||||||||
# Special case: IntEnum/StrEnum literals are subtypes of int/str literals with | ||||||||||||||||||||
# the same value, e.g.: Literal[MyIntEnum.ONE] is a subtype of Literal[1] | ||||||||||||||||||||
# Literal[MyStrEnum.RED] is a subtype of Literal["red"] | ||||||||||||||||||||
# This handles IntEnum, StrEnum, and custom (int, Enum) or (str, Enum) subclasses | ||||||||||||||||||||
if ( | ||||||||||||||||||||
left.is_enum_literal() | ||||||||||||||||||||
and isinstance(left.value, str) # Enum literal values are member names | ||||||||||||||||||||
and self._is_subtype(left.fallback, self.right.fallback) | ||||||||||||||||||||
): | ||||||||||||||||||||
# For IntEnum/StrEnum, check if the enum's actual value matches the literal | ||||||||||||||||||||
# The enum literal's value is the member name (e.g., "ONE" or "RED") | ||||||||||||||||||||
# We need to get the actual value from the enum | ||||||||||||||||||||
enum_value = left.fallback.type.get(left.value) | ||||||||||||||||||||
if enum_value is not None: | ||||||||||||||||||||
enum_type = get_proper_type(enum_value.type) | ||||||||||||||||||||
if isinstance(enum_type, Instance) and enum_type.last_known_value is not None: | ||||||||||||||||||||
# enum_type.last_known_value is the actual value for IntEnum/StrEnum | ||||||||||||||||||||
# members | ||||||||||||||||||||
if enum_type.last_known_value.value == self.right.value: | ||||||||||||||||||||
return True | ||||||||||||||||||||
Comment on lines
+984
to
+988
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Let's collapse the ladder? |
||||||||||||||||||||
return False | ||||||||||||||||||||
else: | ||||||||||||||||||||
return self._is_subtype(left.fallback, self.right) | ||||||||||||||||||||
|
||||||||||||||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better make this
assert
inside the if body: we want a hard failure if enum literal somehow ended up with a non-stringvalue