core/reloader: fix file watcher compatibility with vscode #142
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but could it reasonably end up writing in multiple steps? |
|
This behavior seems related to all Node.js / Electron apps (including vscode and codium) . For example, VSCode’s save process is discussed in this issue: |
outfoxxed
requested changes
Jul 23, 2025
karboggy
force-pushed
the
fix/file-watcher-ignore-truncate-file
branch
from
5a39e44 to
6cfcd31
Compare
karboggy
force-pushed
the
fix/file-watcher-ignore-truncate-file
branch
from
6cfcd31 to
4091407
Compare
outfoxxed
force-pushed
the
fix/file-watcher-ignore-truncate-file
branch
from
4091407 to
3bbf39c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some editors (e.g vscode) can sometimes save files in two steps: truncate + write.
This causes
QFileSystemWatcherto emit thefileChangedsignal twice.It can be visualized with:
inotifywait -m -e modify,create,delete,delete_self,close_write path/to/my-file.qmlOn the first event (truncate), the file size is zero. If quickshell reloads the configuration at this point, it may result to a
Reloading configuration error.This initial event can be safely ignored. The second event (when the file is written) will correctly trigger a reload with valid content.