Skip to content

Fix Makie warning message #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Makie warning message #528

wants to merge 1 commit into from

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Aug 18, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

Try to fix the following warning message from Makie while rendering Bloch sphere vectors:

Arrows3D{Tuple{Vector{GeometryBasics.Point{3, Float32}}, Vector{Vector{Float64}}}} is not supported by cairo right now

Also, remove some redundant imports from our QuantumToolboxMakieExt.

@ytdHuang ytdHuang added the Skip ChangeLog Skip changelog update check in PR label Aug 18, 2025
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.95%. Comparing base (5110d93) to head (8c3d812).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
- Coverage   93.09%   92.95%   -0.15%     
==========================================
  Files          51       51              
  Lines        3549     3548       -1     
==========================================
- Hits         3304     3298       -6     
- Misses        245      250       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ytdHuang
Copy link
Member Author

The warning message also relates to the keyword argument rasterize within arrows3d! function call.

I have posted an issue in Makie.jl: MakieOrg/Makie.jl#5259

Let's wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip ChangeLog Skip changelog update check in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant