Quorum queues Raft machine: preserve order for missing deliveries (get_checked_out) #14386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
changed the title
kjnilsson
requested changes
Aug 18, 2025
| @@ -1091,7 +1091,7 @@ handle_aux(_, _, {get_checked_out, ConsumerKey, MsgIds}, Aux0, RaAux0) -> | |||
| {S, Acc} | |||
| end | |||
| end, {RaAux0, []}, maps:with(MsgIds, Checked)), | |||
| {reply, {ok, IdMsgs}, Aux0, RaState}; | |||
| {reply, {ok, lists:reverse(IdMsgs)}, Aux0, RaState}; | |||
There was a problem hiding this comment.
it needs to be lists:sort/1 instead of lists:reverse, we can't make any assumptions about the maps ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I publish some messages, then call checkout in the another client and get {delivery} Effect, consumer client goes into missing messages and the command doesn't keep the order.
So the test:
publish m1
publish m2
publish m3
checkout
publish m4
Before I got:
m3, m2, m1, m4
And now I get:
m1, m2, m3, m4.