AMQP 1.0, figure 2.33: refuse link instead of terminating the entire session #14389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
force-pushed
the
refuse-link
branch
3 times, most recently
from
37701dc to
7992976
Compare
## What? Refuse or detach the link instead of ending the session. ## Why? Because many errors are scoped to a single terminus, detaching just that link preserves the rest of the session’s links - avoiding needless disruption of other traffic. AMQP 1.0’s error model is hierarchical; RabbitMQ should escalate to ending the session only for session-level faults or if the client keeps using a destroyed link. ## How? Refuse link as per figure 2.33 TODO: * Convert more session-level errors to link-level errors
acogoluegnes
added a commit
to rabbitmq/rabbitmq-amqp-java-client
that referenced
this pull request
Aug 18, 2025
acogoluegnes
added a commit
to rabbitmq/rabbitmq-amqp-java-client
that referenced
this pull request
Aug 18, 2025
michaelklishin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refuse or detach the link instead of ending the session.
Why?
Because many errors are scoped to a single terminus, detaching just that link
preserves the rest of the session’s links - avoiding needless disruption of
other traffic. AMQP's error model is hierarchical; RabbitMQ should escalate to
ending the session only for session-level faults or if the client keeps
using a destroyed link.
How?
Refuse link as per figure 2.33