Fix/readme #14
Open
Fix/readme #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge proof in tests. Some tests fail because proof must be generated in the same day that test pass. One test alway fail because of disabled verifier logic.
violog
reviewed
Aug 5, 2024
| @@ -3,7 +3,7 @@ | |||
| ## Introduction | |||
|
|
|||
| This repository is an SDK for connecting external services with Rarimo passport | |||
| verification system that may be used in back-end services. Its main purpose is | |||
| verification and voting systems that may be used in back-end services. Its main purpose is | |||
There was a problem hiding this comment.
Suggested change
| verification and voting systems that may be used in back-end services. Its main purpose is | |
| passport and voting proof verification system that may be used in back-end services. Its main purpose is |
| @@ -20,16 +20,16 @@ import ( | |||
| ) | |||
|
|
|||
| func main() { | |||
| rv := root.NewVerifier(contractCaller, reqTimeout) | |||
| passportVerifier := root.NewPoseidonSMTVerifier(rpcURL, contractAddress, reqTimeout) | |||
There was a problem hiding this comment.
This is not general usage. Add headers: Passport, Voting, etc.
| root_verifier: | ||
| rpc: https://your-rpc | ||
| contract: 0x... | ||
| verifier: |
There was a problem hiding this comment.
Add examples of using config. It might be either ProvideVerifier() with specified Type or custom initialization without Provider.
| @@ -166,6 +169,12 @@ func WithPollRootVerifier(v root.Verifier) VerifyOption { | |||
| } | |||
| } | |||
|
|
|||
| func withSkipExpirationCheck(check bool) VerifyOption { | |||
There was a problem hiding this comment.
comment that it's only for tests, or make it exported and describe a use case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.