Skip to content

Project refactor home #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: project
Choose a base branch
from
Open

Project refactor home #1388

wants to merge 18 commits into from

Conversation

jochenklar
Copy link
Member

This PR will add the new version of the home page.

@jochenklar jochenklar self-assigned this Jul 1, 2025
@jochenklar jochenklar added this to the RDMO 2.4.0 milestone Jul 1, 2025
@jochenklar jochenklar marked this pull request as ready for review August 14, 2025 09:25
@MyPyDavid MyPyDavid self-requested a review August 14, 2025 09:27
jochenklar and others added 10 commits August 19, 2025 12:07
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid
Copy link
Member

I would like to split up the home template into several parts, so that it easier re-use and change only specific parts instead of copying the whole html file and make only few changes in there.
For example:

  • home_header (it only includes the ones below)
    • home_header_images
    • home_header_text ( this can then also be _de and/or _en)
      I could add that in a separate PR targeting this branch.

I think some placeholders for institutional branding/funding logos would also be nice. What do you think about these type of logos on the bottom of https://about.coscine.de/? I'm not sure about the hover over text but there does need to be some description to each logo..

@jochenklar
Copy link
Member Author

I think this should be done in the theme, and this is why home.html still exists. For "casual" rdmo users I think it is best to have one file (in each language) to edit.

@jochenklar
Copy link
Member Author

I added home_header.html and home_login.html to hide things they do not need to change from those users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants