Skip to content

Build(deps): Migrate to Font Awesome 6 and update package references #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

andrewbrazzatti
Copy link
Contributor

Removing unused packages that are unmaintained.
Upgrading unmaintained packages where possible e.g. Font Awesome 4 to Font Awesome 6

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 57.54190% with 152 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.88%. Comparing base (c5c9f83) to head (65a9e6e).

Files with missing lines Patch % Lines
typescript/api/services/VocabService.ts 5.71% 33 Missing ⚠️
typescript/api/controllers/RecordController.ts 52.00% 24 Missing ⚠️
typescript/api/services/RecordsService.ts 65.71% 10 Missing and 2 partials ⚠️
typescript/api/shims/momentShim.ts 50.00% 11 Missing and 1 partial ⚠️
typescript/api/services/RolesService.ts 59.25% 11 Missing ⚠️
typescript/api/services/RDMPService.ts 54.54% 10 Missing ⚠️
typescript/api/services/UsersService.ts 59.09% 9 Missing ⚠️
typescript/api/services/WorkspaceService.ts 16.66% 5 Missing ⚠️
typescript/api/services/CacheService.ts 71.42% 4 Missing ⚠️
typescript/api/services/AsynchsService.ts 25.00% 3 Missing ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3240      +/-   ##
===========================================
+ Coverage    48.79%   48.88%   +0.09%     
===========================================
  Files          183      184       +1     
  Lines        10755    10794      +39     
  Branches      1613     1624      +11     
===========================================
+ Hits          5248     5277      +29     
- Misses        5277     5286       +9     
- Partials       230      231       +1     
Flag Coverage Δ
backend-bruno 39.98% <51.11%> (+0.05%) ⬆️
backend-mocha 44.96% <57.54%> (+0.12%) ⬆️
frontend-app-config 97.87% <ø> (ø)
frontend-core-lib 53.78% <ø> (ø)
frontend-dashboard 74.53% <ø> (ø)
frontend-deleted-records 86.59% <ø> (ø)
frontend-export 100.00% <ø> (ø)
frontend-local-auth 100.00% <ø> (ø)
frontend-manage-roles 63.33% <ø> (ø)
frontend-manage-users 59.81% <ø> (ø)
frontend-report 95.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* Refactor: Replace moment.js with Luxon for date handling and add momentShim for backwards compatibility

* Refactor: Move momentShim to a new location and update import paths

* Build(deps): Update sails-hook-redbox-storage-mongo to version 1.5.0

* Refactor: Remove unused readme files and add momentShim for Luxon compatibility

* Refactor: Replace moment.js with Luxon in NamedQueryService tests for date handling

* Reinstated readme.md that was accidentally removed while moving the shim
andrewbrazzatti and others added 2 commits August 14, 2025 16:00
* Bump rxjs from 6.6.2 to 7.8.1

Bumps [rxjs](https://github.com/reactivex/rxjs) from 6.6.2 to 7.8.1.
- [Release notes](https://github.com/reactivex/rxjs/releases)
- [Changelog](https://github.com/ReactiveX/rxjs/blob/7.8.1/CHANGELOG.md)
- [Commits](ReactiveX/rxjs@6.6.2...7.8.1)

---
updated-dependencies:
- dependency-name: rxjs
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Initial migration. No compilation errors

* Refactor RxJS imports and replace deprecated `toPromise` with `firstValueFrom` in multiple services

- Updated imports from 'rxjs/Rx' to 'rxjs' for consistency and clarity.
- Replaced deprecated `toPromise()` method with `firstValueFrom()` in various service files to improve promise handling.
- Adjusted observable handling to use `from()` and `of()` where applicable.
- Removed unnecessary imports and cleaned up code for better readability and maintainability.

* Bumped version to 1.5.0

* Updated storage hook dependency to v1.5.1 which supports the latest rxjs and remove unused imports in DoiService

* Update sails-hook-redbox-storage-mongo dependency to v1.5.2

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants