Initial SaveButtonComponent implementation

[shilob]

This pull request introduces a new SaveButtonComponent to the Angular form system and refactors the form handling logic to use Angular signals for better reactivity and maintainability. The changes include the implementation of the save button, updates to the form component to support signal-based parameters and save logic, and the integration of the new component into the form's module and static dictionary. Additionally, comprehensive unit tests for the SaveButtonComponent are added.

New Save Button Feature:

• Implemented SaveButtonComponent:

  • Adds a save button that interacts with the parent form, triggers save logic, and disables itself when the form is unchanged or invalid.
  • Integrated into the form module, static component dictionary, and test helpers for full support. [1] [2] [3] [4] [5] [6]

• Added unit tests for SaveButtonComponent:

  • Tests creation, save action, and disabled state when the form is unchanged.

Form Component Refactoring and Enhancements:

• Refactored FormComponent to use Angular signals:

  • Replaced @Input properties with signals for oid, recordType, formName, editMode, and downloadAndCreateOnInit.
  • Added logic to handle changes to these parameters, including reinitializing the form when the OID changes. [1] [2] [3] [4] [5] [6]
  • Updated all usages of these properties to use the new signal-based approach. [1] [2]

• Implemented form save logic:

  • Added saveForm method to handle form submission, including validation, pristine/dirty checks, and status updates.
  • Integrated with a RecordService for create/update actions and error handling.
  • Exposed dataStatus for use by child components (e.g., SaveButtonComponent).

Minor Cleanup:

• Removed unused getter from TabContentComponent.
• Minor import cleanup in base form field component.

These changes collectively improve the form system's usability, testability, and maintainability, and introduce a reusable save button component.

[Copilot]

Pull Request Overview

This PR introduces a new SaveButtonComponent for Angular forms and refactors the FormComponent to use signals for better reactivity. The main purpose is to add a save button that can interact with the parent form, trigger save logic, and disable itself when the form is unchanged or invalid.

• Implementation of a new SaveButtonComponent with configuration options for save behavior
• Refactoring of FormComponent to use Angular signals instead of @Input properties for better reactivity
• Addition of form save logic with create/update operations via RecordService

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
typescript/form-config/default-1.0-draft.ts	Adds save button configuration and minor formatting updates
packages/sails-ng-common/src/config/component/save-button.model.ts	Defines TypeScript model interfaces for the SaveButtonComponent
packages/sails-ng-common/src/config/component/index.ts	Exports the new save button model types
angular/projects/researchdatabox/portal-ng-common/src/lib/utility.service.ts	Adds utility method for handling string signals
angular/projects/researchdatabox/portal-ng-common/src/lib/record.service.ts	Implements create/update methods and result type for record operations
angular/projects/researchdatabox/portal-ng-common/src/lib/form/form-field-base.component.ts	Minor cleanup of import and access modifier
angular/projects/researchdatabox/form/src/app/static-comp-field.dictionary.ts	Registers SaveButtonComponent in the component dictionary
angular/projects/researchdatabox/form/src/app/helpers.spec.ts	Updates test helpers to support new signal-based FormComponent API
angular/projects/researchdatabox/form/src/app/form.module.ts	Declares SaveButtonComponent in the module
angular/projects/researchdatabox/form/src/app/form.component.ts	Major refactoring to use signals and adds save functionality
angular/projects/researchdatabox/form/src/app/component/tab.component.ts	Removes unused getter method
angular/projects/researchdatabox/form/src/app/component/save-button.component.ts	Implements the new SaveButtonComponent
angular/projects/researchdatabox/form/src/app/component/save-button.component.spec.ts	Adds comprehensive unit tests for SaveButtonComponent

Comments suppressed due to low confidence (1)

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.97%. Comparing base (709cf65) to head (4a1d733).

Additional details and impacted files

@@                  Coverage Diff                   @@
##           feature/ng19-forms    #3261      +/-   ##
======================================================
+ Coverage               49.93%   49.97%   +0.04%     
======================================================
  Files                     199      200       +1     
  Lines                   12147    12213      +66     
  Branches                 1984     2008      +24     
======================================================
+ Hits                     6065     6103      +38     
- Misses                   5821     5849      +28     
  Partials                  261      261              

Flag	Coverage Δ
backend-bruno	38.66% <ø> (ø)
backend-mocha	45.20% <ø> (ø)
frontend-app-config	97.87% <ø> (ø)
frontend-core-lib	51.75% <ø> (-0.41%)	⬇️
frontend-dashboard	74.53% <ø> (ø)
frontend-deleted-records	86.59% <ø> (ø)
frontend-export	100.00% <ø> (ø)
frontend-form	62.74% <ø> (-0.10%)	⬇️
frontend-local-auth	100.00% <ø> (ø)
frontend-manage-roles	63.33% <ø> (ø)
frontend-manage-users	59.81% <ø> (ø)
frontend-report	95.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cofiem]

What's the motivation for using model signals? I think it makes sense, but I want to know what prompted the change?

[shilob]

What's the motivation for using model signals? I think it makes sense, but I want to know what prompted the change?

To enable two-way integration if another NG component is creating and is interested in the Form app's OID and other parameters.