Widget.attach to a given element instead of only an element id #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This includes changes unrelated to the DOM element handling. Please do separate PRs for separate changes, because we can't easily merge a new feature or improvement, if we have to verify a changed build process etc. all in the same changeset. It also makes discussing the changes more difficult. If one changeset depends on another one, then you can open one PR and then open another one against the first PR/branch. Also, release builds should only be committed in release commits (done automatically on |
|
Sorry for the delay, I reviewed the code and removed Vite.js @raucao 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #140.