Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

feat: add auth_oauth #132

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add auth_oauth #132

wants to merge 2 commits into from

Conversation

Blckbrry-Pi
Copy link
Contributor

No description provided.

This was referenced Jul 20, 2024
Closed
Merged
Closed
@Blckbrry-Pi Graphite App
Copy link
Contributor Author

Blckbrry-Pi commented Jul 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Blckbrry-Pi and the rest of your teammates on Graphite Graphite

@Blckbrry-Pi Blckbrry-Pi changed the title eat: Create the auth_username_pasword module feat: Create the auth_username_pasword module Jul 20, 2024
@Blckbrry-Pi Blckbrry-Pi marked this pull request as ready for review July 20, 2024 17:35
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from 7a771d2 to a84215f Compare July 20, 2024 17:42
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-20-eat_create_the_auth_username_pasword_module branch from 461712a to 2873938 Compare July 20, 2024 17:43
@Blckbrry-Pi Blckbrry-Pi changed the title feat: Create the auth_username_pasword module feat: Create identity provider modules auth_username_pasword, auth_email, and auth_oauth Jul 22, 2024
NathanFlurry
NathanFlurry suggested changes Aug 2, 2024
View reviewed changes
modules/auth_oauth2/config.ts
@@ -0,0 +1,11 @@
export interface Config {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename this to customProviders and add pre-configured blocks for google, facebook, etc.

see the repo i sent an while back for reference on pre-made configs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. This will require some reworking however, and IMO that functionality should be provided by a google or facebook module.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok cool let's get the interface stable then by just renaming this to "customProviders" and add presets later

@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-20-eat_create_the_auth_username_pasword_module branch from 85377b5 to 5520319 Compare August 3, 2024 17:14
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from a84215f to 564ae91 Compare August 3, 2024 17:47
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-20-eat_create_the_auth_username_pasword_module branch from 5520319 to 3b421b9 Compare August 3, 2024 17:47
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from 564ae91 to 1b445c7 Compare August 3, 2024 21:59
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-20-eat_create_the_auth_username_pasword_module branch from 3b421b9 to ea83953 Compare August 3, 2024 21:59
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from 1b445c7 to 91cb526 Compare August 3, 2024 22:57
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-20-eat_create_the_auth_username_pasword_module branch 4 times, most recently from 5b70e06 to ef45e3e Compare August 4, 2024 20:06
NathanFlurry
NathanFlurry suggested changes Aug 4, 2024
View reviewed changes
modules/auth_oauth2/config.ts
@@ -0,0 +1,11 @@
export interface Config {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok cool let's get the interface stable then by just renaming this to "customProviders" and add presets later

NathanFlurry
NathanFlurry suggested changes Aug 5, 2024
View reviewed changes
modules/auth_email/utils/link_assertions.ts Outdated
IDENTITY_INFO_PASSWORDLESS,
} from "./provider.ts";

export async function ensureNotAssociated(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repost: this is very very expensive, it does at least 3 round trips to the database before doing anything else in the request. we should expose a batch api on identities module for this.

to answer the q: it should be very easy to pass multiple identity types to the query so it can be configurable. but also, that won't be a breaking change, so go for the simpler option.

modules/tokens/public.ts Outdated
return output;
}

export function generateRandomCodeSecure(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat. we need ot refactor tokens itself to use this function since it still depends on an insecure version.

@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from 91cb526 to 7677207 Compare August 7, 2024 21:32
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-20-eat_create_the_auth_username_pasword_module branch 2 times, most recently from eac22ac to 53d1543 Compare August 7, 2024 21:50
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from 7677207 to 392079a Compare August 7, 2024 22:08
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-20-eat_create_the_auth_username_pasword_module branch from 53d1543 to 709f613 Compare August 7, 2024 22:08
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from 392079a to b504d85 Compare August 7, 2024 22:09
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-20-eat_create_the_auth_username_pasword_module branch 2 times, most recently from 32352b5 to 658d5a4 Compare August 8, 2024 20:26
@MasterPtato MasterPtato removed their request for review August 23, 2024 23:28
@NathanFlurry NathanFlurry force-pushed the 07-04-feat_create_the_user_passwords_module branch from b504d85 to 8358d72 Compare August 24, 2024 02:47
@NathanFlurry NathanFlurry force-pushed the 07-20-eat_create_the_auth_username_pasword_module branch 2 times, most recently from b85d1e6 to 64571da Compare August 24, 2024 02:56
@NathanFlurry NathanFlurry changed the base branch from 07-04-feat_create_the_user_passwords_module to 08-23-feat_email_email_link_email_password_email_passwordless_and_username_password_auth_methods August 24, 2024 02:56
@NathanFlurry NathanFlurry mentioned this pull request Aug 24, 2024
Merged
@NathanFlurry NathanFlurry changed the title feat: Create identity provider modules auth_username_pasword, auth_email, and auth_oauth feat: add auth_oauth Aug 24, 2024
@NathanFlurry NathanFlurry changed the base branch from 08-23-feat_email_email_link_email_password_email_passwordless_and_username_password_auth_methods to graphite-base/132 August 24, 2024 03:06
@NathanFlurry NathanFlurry force-pushed the 07-20-eat_create_the_auth_username_pasword_module branch from 64571da to c724d76 Compare August 24, 2024 03:08
@NathanFlurry NathanFlurry changed the base branch from graphite-base/132 to main August 24, 2024 03:09
@NathanFlurry NathanFlurry force-pushed the 07-20-eat_create_the_auth_username_pasword_module branch from c724d76 to 7767658 Compare August 24, 2024 03:09
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-20-eat_create_the_auth_username_pasword_module branch from 7767658 to c9ea5ef Compare August 24, 2024 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@NathanFlurry NathanFlurry NathanFlurry requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blckbrry-Pi @NathanFlurry