Fix 4707 - Fixed additional properties for daisyui theme #4722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
force-pushed
the
fix-4707
branch
from
9953ef5 to
7580c00
Compare
Fixes rjsf-team#4707 by rendering the `WrapIfAdditionalTemplate` inside of the `FieldTemplate` - Updated the `WrapIfAdditionalTemplate` to properly render the delete button and key input around the `children` when the schema element is an additional property - Updated the `FieldTemplate` to properly wrap the Field with the `WrapIfAdditionalTemplate` - Updated the snapshots accordingly - Updated the `CHANGELOG.md` accordingly
heath-freenome
force-pushed
the
fix-4707
branch
from
7580c00 to
344196e
Compare
nickgros
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #4707 by rendering the
WrapIfAdditionalTemplateinside of theFieldTemplateWrapIfAdditionalTemplateto properly render the delete button and key input around thechildrenwhen the schema element is an additional propertyFieldTemplateto properly wrap the Field with theWrapIfAdditionalTemplateCHANGELOG.mdaccordinglyBefore:
After:
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.