Fixed range checking for floating-type parameters #2904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
requested changes
Jul 14, 2025
| { | ||
| const rclcpp::Parameter new_parameter = rclcpp::Parameter( | ||
| "double_parameter", | ||
| std::numeric_limits<double>::infinity() |
There was a problem hiding this comment.
@matemat13 thanks for creating PR.
can you retarget this fix to rolling branch? that is where we develop the code 1st. btw, code base is bit different from jazzy and rolling around this area.
| if ((v < fp_range.from_value) || (v > fp_range.to_value)) { | ||
| const double v = value.get<double>(); | ||
| const auto& fp_range = descriptor.floating_point_range.at(0); | ||
| const bool within_range = (v >= fp_range.from_value) && (v <= fp_range.to_value); |
There was a problem hiding this comment.
This removed the epsilon, shouldn't it be
Suggested change
| const bool within_range = (v >= fp_range.from_value) && (v <= fp_range.to_value); | |
| const bool within_range = (v >= fp_range.from_value - std::numeric_limits<double>::epsilon() ) && (v <= fp_range.to_value + + std::numeric_limits<double>::epsilon() ); |
Also, if the __are_doubles_equal function is obviously broken, why was it not removed ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2898
Is this user-facing behavior change?
Yes. Trying to set a floating-point parameter with a configured range to a value outside this range that is either
inf,-inf, ornanwill now correctly fail.Did you use Generative AI?
No.
Additional Information
Nothing that comes to mind.