-
Notifications
You must be signed in to change notification settings - Fork 0
Dots #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
What information do I need in order to draw dots?
These properties are mostly calculated during a letter's So, I can either draw dots during
What configuration settings are needed for dots?
|
The dot curves on letters that would have dots are now indicated with debug lines. There are different implementations for full (p, f) and unfull (s, d) blocks - full blocks have an entire circle, but unfull blocks just have a start and end point with a curve drawn between them. The angle on which to place the dots on a full block could possibly even be random, although for the f block, it must not cross the word line. The distance between the dot curve and the letter curve is a bit wack. The current implementation is a naive, with the difference in radii just being a ratio of the letter's radius, which is not ideal and is open to unsightly differences between blocks.
Dots are now centre-aligned and evenly spaced across the curve of a letter for s and d blocks: I'm not happy with the dot placement. For the d block, it looks fine until there's a vowel overlapping. For the s block, it looks like shit, and when there's a lot of stuff going on in the image they even overlap with their letters. The dots are currently
I want the dots to be a distance away from their letter that is constant across the whole word, so that calculation can't be a simple fraction of the letter's radius as it is currently. I also want to keep that same distance even when the dot size varies, so they can't be placed directly onto that line - they need to be placed such that they're tangential. |
In #64 I concluded that it'd probably be easier to start with dots before I try to implement lines.
The guide seems to have 4 different implicit dot settings:
Although looking at it... different rules probably apply to each block. Let's see if I can't work out a standard solution for each block. Note that in addition to this, the sentence itself can have dots for punctuation, but we'll get to that later (#3).
Tasks for this PR:
Closes #43.
Test phrase:
chd dadedidodu phklc cacecicocu whshr rareriroru ghyzq qaqeqiqoqu