-
Notifications
You must be signed in to change notification settings - Fork 3
Waypointによるナビゲーションサンプルの追加 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gazeboで動作確認できました。
いくつかコメントしたのでご確認をお願いいたします。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
READMEとサンプルの実装以外の部分でコメントしました。
サンプルはあとで確認します。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます。ドキュメントわかりやすいです!
いくつかコメントしました。
raspimouse_navigation_examples/raspimouse_navigation_examples/waypoint.py
Outdated
Show resolved
Hide resolved
raspimouse_navigation_examples/raspimouse_navigation_examples/waypoint.py
Outdated
Show resolved
Hide resolved
raspimouse_navigation_examples/raspimouse_navigation_examples/waypoint.py
Show resolved
Hide resolved
raspimouse_navigation_examples/raspimouse_navigation_examples/waypoint.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
もう一点コメントしました。
Co-authored-by: Kuwamai <kuwagata@rt-net.jp>
Co-authored-by: Kuwamai <kuwagata@rt-net.jp>
Co-authored-by: Kuwamai <kuwagata@rt-net.jp>
Co-authored-by: Kuwamai <kuwagata@rt-net.jp>
Co-authored-by: Kuwamai <kuwagata@rt-net.jp>
一部冗長となっていたので、全体的な章構成を変更しました。 |
修正が完了しました。再度レビューをお願いします。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです。
What does this implement/fix?
Waypointによるナビゲーションサンプルを追加します。
Does this close any currently open issues?
しません。
How has this been tested?
シミュレーションと実機で動作確認をしました。
実験環境
動作方法
以下のコマンドでWaypointナビゲーションサンプルを実行します。
$HOME/MAP_NAME.yaml
の地図データを作成済みで、LiDARはRP LiDAR A1を前提としています。実機
シミュレータ(Gazebo)
Any other comments?
Checklists