Run-3409: Ansible model sources return host vars data in key value format when gather facts is set to no

[edbaltra]

Summary

This PR addresses an issue where host variables with structured data (such as lists or maps) — for example, the ports attribute returned by dynamic Ansible inventories like nmap — were being imported into Rundeck as flattened Java toString() representations when gather_facts was set to false.

What was done:

• Modified createNodeEntry(...) to serialize Map and List values using Gson.toJson() instead of relying on .toString().
• Ensured structured data (like lists of open ports) are stored as valid JSON strings in node attributes.

This change ensures consistent and parseable structured data in Rundeck’s node model, even when Ansible fact gathering is disabled.

---

Jira Ticket

RUN-3409 – Ansible Model Sources return host vars data in key=value format when "Gather Facts" is set to "no"

[Copilot]

Pull Request Overview

This PR enhances how structured host variables (e.g., lists/maps) are stored when gather_facts is disabled by serializing them as JSON rather than using toString().

• Adds SLF4J Logger (though a Lombok @Slf4j logger already exists)
• Introduces on-the-fly Gson instantiation in createNodeEntry
• Wraps attribute setting to handle Map/List via Gson.toJson()

Comments suppressed due to low confidence (2)

src/main/groovy/com/rundeck/plugins/ansible/plugin/AnsibleResourceModelSource.java:809

• There are no tests verifying that Map/List values are correctly serialized to JSON and stored in attributes. Adding a unit test for createNodeEntry with structured data would help prevent regressions.

nodeValues.forEach((key, value) -> {

src/main/groovy/com/rundeck/plugins/ansible/plugin/AnsibleResourceModelSource.java:73

• The class is already annotated with Lombok’s @slf4j, which provides a 'log' instance. Consider removing this redundant 'logger' field to avoid confusion and duplicate loggers.

private static final Logger logger = LoggerFactory.getLogger(AnsibleResourceModelSource.class);