-
Notifications
You must be signed in to change notification settings - Fork 161
Version Updates #1677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Updates #1677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These break a few things so setting back to draft mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the project to Node 22.12.0, updates VuePress to the latest RC versions, and adds custom layouts/announcements while cleaning up obsolete components.
- Bump Node version references in
.nvmrc
, CircleCI, andREADME.md
- Update VuePress core and plugin versions to
2.0.0-rc.24
/rc.112
- Introduce custom 404 and layout announcements; remove unused alias/components
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
package.json | Updated VuePress and related plugin versions |
docs/manual/05-nodes.md | Changed link format for the rd nodes command |
docs/api/index.md | Replaced headerDepth with toc.levels in frontmatter |
docs/.vuepress/layouts/NotFound.vue | Added a custom 404 page template with analytics tracking |
docs/.vuepress/layouts/Layout.vue | Added hero/sidebar announcements via new layout slots |
docs/.vuepress/config.ts | Toggled debug via NODE_ENV ; removed unused Prism import |
docs/.vuepress/components/SidebarAnnounce.vue | Removed obsolete sidebar announcement component |
docs/.vuepress/components/HomePageAnnounce.vue | Removed obsolete homepage announcement component |
docs/.vuepress/client.ts | Registered Layout and NotFound in client config |
README.md | Updated Node version note; added “Documentation Structure” |
.nvmrc | Switched from 18.19.0 to 22.12.0 |
.circleci/config.yml | Updated Docker image to cimg/node:22.12.0 |
Comments suppressed due to low confidence (1)
docs/.vuepress/layouts/Layout.vue:14
- There's a missing space between the
v-if
attribute andclass
. It should be<div v-if="isHomePage" class="homepage-announce">
to avoid a template parse error.
<div v-if="isHomePage"class="homepage-announce">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Brings Node up to version 22.12.0.
NOTE: Testing this will require deleting
node_modules
andpackage-lock.json
. Then usingnvm install; nvm use;
to switch the NodeJS version.