Skip to content

Version Updates #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2025
Merged

Version Updates #1677

merged 4 commits into from
Jul 15, 2025

Conversation

fdevans
Copy link
Contributor

@fdevans fdevans commented Jul 11, 2025

Brings Node up to version 22.12.0.

NOTE: Testing this will require deleting node_modules and package-lock.json. Then using nvm install; nvm use; to switch the NodeJS version.

@fdevans fdevans added this to the 5.14.0 milestone Jul 11, 2025
@fdevans fdevans requested review from jsboak and Copilot July 11, 2025 20:01
Copilot

This comment was marked as outdated.

jsboak
jsboak previously approved these changes Jul 11, 2025
Copy link
Contributor

@jsboak jsboak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdevans
Copy link
Contributor Author

fdevans commented Jul 11, 2025

These break a few things so setting back to draft mode.

@fdevans fdevans marked this pull request as draft July 11, 2025 22:28
@fdevans fdevans requested review from jsboak and removed request for jsboak July 11, 2025 22:28
@fdevans fdevans requested a review from jsboak July 12, 2025 01:05
@fdevans fdevans marked this pull request as ready for review July 12, 2025 01:05
@fdevans fdevans requested a review from Copilot July 12, 2025 01:05
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project to Node 22.12.0, updates VuePress to the latest RC versions, and adds custom layouts/announcements while cleaning up obsolete components.

  • Bump Node version references in .nvmrc, CircleCI, and README.md
  • Update VuePress core and plugin versions to 2.0.0-rc.24/rc.112
  • Introduce custom 404 and layout announcements; remove unused alias/components

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Updated VuePress and related plugin versions
docs/manual/05-nodes.md Changed link format for the rd nodes command
docs/api/index.md Replaced headerDepth with toc.levels in frontmatter
docs/.vuepress/layouts/NotFound.vue Added a custom 404 page template with analytics tracking
docs/.vuepress/layouts/Layout.vue Added hero/sidebar announcements via new layout slots
docs/.vuepress/config.ts Toggled debug via NODE_ENV; removed unused Prism import
docs/.vuepress/components/SidebarAnnounce.vue Removed obsolete sidebar announcement component
docs/.vuepress/components/HomePageAnnounce.vue Removed obsolete homepage announcement component
docs/.vuepress/client.ts Registered Layout and NotFound in client config
README.md Updated Node version note; added “Documentation Structure”
.nvmrc Switched from 18.19.0 to 22.12.0
.circleci/config.yml Updated Docker image to cimg/node:22.12.0
Comments suppressed due to low confidence (1)

docs/.vuepress/layouts/Layout.vue:14

  • There's a missing space between the v-if attribute and class. It should be <div v-if="isHomePage" class="homepage-announce"> to avoid a template parse error.
      <div v-if="isHomePage"class="homepage-announce">

Copy link
Contributor

@jsboak jsboak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdevans fdevans merged commit b808680 into 4.0.x Jul 15, 2025
1 check passed
@fdevans fdevans deleted the version-fixups branch July 15, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants