Skip to content

Re-implement Previous Versions #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Re-implement Previous Versions #1679

merged 1 commit into from
Jul 15, 2025

Conversation

fdevans
Copy link
Contributor

@fdevans fdevans commented Jul 15, 2025

No description provided.

@fdevans fdevans added this to the 5.14.0 milestone Jul 15, 2025
@fdevans fdevans requested review from jsboak and Copilot July 15, 2025 15:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-implements previous version documentation links by moving them from the navbar to the sidebar. The version links that were previously accessible through the navbar are now reorganized and made available through the history sidebar menu.

  • Removes the existing navbar-based previous versions menu structure
  • Adds a comprehensive "Previous Version Docs" section to the history sidebar with collapsible version groups
  • Maintains all the same version links but organizes them hierarchically by major version (5.x, 4.x, 3.x, 2.x)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/.vuepress/sidebar-menus/history.ts Adds new "Previous Version Docs" section with hierarchical version organization
docs/.vuepress/navbar-menus/previous-versions.js Removes entire file containing previous navbar menu structure
Comments suppressed due to low confidence (1)

docs/.vuepress/sidebar-menus/history.ts:10

  • The hardcoded version list creates a maintenance burden. Consider generating this list dynamically from a configuration file or API to avoid manual updates for each new version release.
    children: [

Copy link
Contributor

@jsboak jsboak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdevans fdevans merged commit e038910 into 4.0.x Jul 15, 2025
2 checks passed
@fdevans fdevans deleted the previous-versions branch July 15, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants