-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(unstable): Added -Zbuild-dir-new-layout
unstable feature
#15848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(unstable): Added -Zbuild-dir-new-layout
unstable feature
#15848
Conversation
07836ed
to
c519405
Compare
oops, disregard the last push. I mistakenly pushed the wip layout implementation to the wrong branch. Reverted that commit |
|
||
* Tracking Issue: [#15010](https://github.com/rust-lang/cargo/issues/15010) | ||
|
||
Enables the new build-dir filesystem layout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new layout won't be that useful enough to stabilize on its own, right? Anyway the layout changing itself could lead to unexpected breakages to workflow making assumption of the layout, so agree it is better having its own unstable flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new layout won't be that useful enough to stabilize on its own, right? Anyway the layout changing itself could lead to unexpected breakages to workflow making assumption of the layout, so agree it is better having its own unstable flag.
Yeah it seems unlikely that this alone would give users a tangible benefit, but I think there is value in allowing tool authors to test their cargo integration with the new layout.
Part of me is wondering if it would be a good idea to bundle the layout changes with moving the default build-dir
location to inside of CARGO_HOME
(or perhaps using XDG config #1734 ?)
My thought is that it might be easier to bundle both of these changes together to avoid churn in the default build-dir
behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not? I feel like they are different kinds of churn. And XDG is always a hot topic that I am afraid of touching 😆.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that these are independent changes.
My hope was to have fine grained locking be the feature to push this to being stabilized.
What does this PR try to resolve?
Added
-Zbuild-dir-new-layout
unstable feature as part of #15010I will open a follow up PR with an initial implementation as mentioned here
r? @weihanglo