Added better filesystem layout testing harness #15874
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't look at the change, but thanks a lot for improving the test infrastructure! |
epage
reviewed
Aug 21, 2025
| // Match multi-part hashes like 06/b451d0d6f88b1d used in directory paths | ||
| subs.insert("[HASH]", regex!(r"/(?<redacted>[a-f0-9]{2}\/[0-9a-f]{14})")) | ||
| .unwrap(); | ||
| subs.insert("[HASH]", regex!(r"[a-z0-9]+-(?<redacted>[a-f0-9]{16})")) |
There was a problem hiding this comment.
Whats this redaction covering?
There was a problem hiding this comment.
this is handling the hashes in file/dir names in the fingerprint/build dirs
└── debug
├── .cargo-lock
├── .fingerprint
│ └── foo-[HASH]
│ ├── bin-foo
│ ├── bin-foo.json
│ ├── dep-bin-foo
│ └── invoked.timestamp
There was a problem hiding this comment.
Could you add a corresponding comment?
There was a problem hiding this comment.
although I think the first multi-part hash is incorrect now. (I added that when I was still experimenting with a flat file paths)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
The goal is to make filesystem layout tests easier to understand and review.
The
build-dirtest's have a helper fns that have imperative checks. While this works, its not easy to see what its validating at a glance.My thought is to reuse the snapbox infrastructure we already have for the cargo ui tests.
The prototype in this PR generates a file tree (like the unix tree command) and uses snapbox to compare against a snapshot. This makes the layout tests much easier to read and failures are much more obvious what what went wrong.
However there are some problems with the current implementation that limit the usefulness of it.
dSYMon macos└── foo-[HASH].dSYM [cfg(target_os = "macos")]└,├,│) to handle optional files.target/<profile>/build/pkg-[HASH]directories. The hash changes the order of the directories when generating the tree making snapshots inconsistent.[HASH], but this does not help with the order.