Skip to content

Conversation

sonnykt
Copy link
Member

@sonnykt sonnykt commented Jan 31, 2025

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@sonnykt sonnykt added the Needs review Dev complete ready for review label Jan 31, 2025
@sonnykt sonnykt self-assigned this Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cac5cdf) to head (c1e52b2).
Report is 1 commits behind head on 1.x.

Additional details and impacted files
@@             Coverage Diff             @@
##                 1.x       #48   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       279       279           
===========================================
  Files             16        16           
  Lines           1124      1125    +1     
===========================================
+ Hits            1124      1125    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonnykt sonnykt merged commit c1e52b2 into 1.x Jan 31, 2025
15 checks passed
@sonnykt sonnykt deleted the feature/fix_serialize_closure branch January 31, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs review Dev complete ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant