1207 convert cca wizard to react #1216
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mletter1
force-pushed
the
1207-convert-cca-wizard-to-react
branch
from
9683435 to
e69785b
Compare
Mletter1
force-pushed
the
1207-convert-cca-wizard-to-react
branch
from
7e3a36b to
91f37af
Compare
Mletter1
force-pushed
the
1207-convert-cca-wizard-to-react
branch
2 times, most recently
from
5a22858 to
a3d9ae7
Compare
Mletter1
force-pushed
the
1207-convert-cca-wizard-to-react
branch
from
2616b0a to
2665f6a
Compare
Mletter1
force-pushed
the
1207-convert-cca-wizard-to-react
branch
from
c17918a to
7bde842
Compare
Mletter1
force-pushed
the
1207-convert-cca-wizard-to-react
branch
from
58ee95d to
b402882
Compare
Mletter1
changed the title
Mletter1
force-pushed
the
1207-convert-cca-wizard-to-react
branch
from
845b0ee to
4a86c1e
Compare
There was a problem hiding this comment.
Filename should probably be CCAWizardSlice (first C capitalized)?
| export const selectAttributes = (state: RootState) => state.cCAWizard.attributes; | ||
| export const selectScaleInputs = (state: RootState) => state.cCAWizard.scaleInputs; | ||
| export const selectMarking = (state: RootState) => state.cCAWizard.marking; | ||
| export const selectDescription = (state: RootState) => state.cCAWizard.marking; |
There was a problem hiding this comment.
selectDescription is selecting marking instead of description
| export const selectScaleInputs = (state: RootState) => state.cCAWizard.scaleInputs; | ||
| export const selectMarking = (state: RootState) => state.cCAWizard.marking; | ||
| export const selectDescription = (state: RootState) => state.cCAWizard.marking; | ||
| export const selectName = (state: RootState) => state.cCAWizard.marking; |
There was a problem hiding this comment.
selectName is also selecting marking
| <div className="form-group mt-3"> | ||
| <div className="form-check pl-1"> | ||
| <label> | ||
| <input type="checkbox" data-bind="checked: scale_inputs" /> Scale to unit variance |
There was a problem hiding this comment.
This looks like it's still using knockout code (data-bind) and is not hooked up to Redux state.
| import client from "js/slycat-web-client"; | ||
| import fileUploader from "js/slycat-file-uploader-factory"; | ||
| import * as dialog from "js/slycat-dialog"; | ||
| import { REMOTE_AUTH_LABELS } from "../../../../utils/ui-labels"; |
There was a problem hiding this comment.
I think you can import utils with "utils/ui-labels" since webpack is set to look in web-server as its root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.