Feature/SK-1717 | Start combiner server if run as __main__ #982
+32
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several configuration and startup changes for the combiner service, focusing on how it loads configuration files, sets environment variables, and starts the service process. The changes improve flexibility and standardization in configuration management and service initialization.
Configuration management improvements:
FEDN_COMBINER_CONFIG
environment variable infedn/common/config.py
, with a default fallback location.config/settings-combiner.yaml.local.template
andconfig/settings-combiner.yaml.template
) to include new fieldsfqdn
andsecure
for more flexible network configuration. [1] [2]Service startup and Docker integration:
docker-compose.yaml
to start the combiner using a Python script (combiner.py
) instead of the previous CLI command, and added theFEDN_COMBINER_CONFIG
environment variable to the container environment. [1] [2]fedn/network/combiner/combiner.py
to load configuration from the file specified byFEDN_COMBINER_CONFIG
, validate its existence, and initialize the service using the loaded configuration. [1] [2] [3]