-
Notifications
You must be signed in to change notification settings - Fork 17
update Makefile #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Makefile #121
Conversation
WalkthroughThe Makefile was updated so that the Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Makefile (1)
24-24
: Masking lint failures can hide issues
The trailing|| :
silences all errors from the lint script, preventing CI from failing on genuine issues. Consider removing it so lint violations break the build and get addressed promptly.Apply this diff:
-lint: deps - sh ./golangci-lint.sh || : +lint: deps + sh ./golangci-lint.sh
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Makefile
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (go)
- GitHub Check: Test
- GitHub Check: Linting
🔇 Additional comments (1)
Makefile (1)
24-24
: Explicit shell invocation improves portability
Usingsh ./golangci-lint.sh
ensures the script runs regardless of executable permissions or shebang quirks.
Please, ensure your pull request meet these guidelines:
I have run
make lint
,or I have used https://goreportcard.com/
and I have taken the necessary compliance actions.
Thanks for your PR, you're awesome! 👍
Summary by CodeRabbit