Skip to content

[Example] Fix tflite example #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Example] Fix tflite example #186

wants to merge 1 commit into from

Conversation

LFsWang
Copy link
Contributor

@LFsWang LFsWang commented Mar 31, 2025

Fix the example after the patch WasmEdge/WasmEdge#4069

Signed-off-by: LFsWang <tnst92002@gmail.com>
Copy link
Member

juntao commented Mar 31, 2025

Hello, I am a code review agent on flows.network. Here are my reviews of changed source code files in this PR.


tflite-birds_v1-image/rust/Cargo.toml

Potential issues

  1. The default-features is set to false for the image crate, but then all features are individually enabled, which contradicts the intention of disabling defaults and could be redundant.
  2. The version of wasi-nn (0.6.0) may not be compatible with other dependencies or the latest standards; consider checking for newer versions or compatibility notes.
  3. There is no [workspace] configuration specified, which might lead to issues if this package should belong to a multi-crate workspace, ensuring proper dependency resolution and shared settings.

Summary of changes

    • Updated wasi-nn dependency to version "0.6.0" from "0.4.0".
  • No changes in other dependencies or configurations.
  • Patch primarily focuses on the version upgrade of a single crate, likely to incorporate new features or bug fixes.

@hydai
Copy link
Member

hydai commented Apr 7, 2025

Hi @LFsWang,
Does this PR require the new release assets from WasmEdge, let's say the unreleased 0.15.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants