Skip to content

[WIP] append to sequence file output #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented May 22, 2025

Example usage:

seqan3::sequence_file_output fout{"/tmp/test.sam",
                                  seqan3::fields<seqan3::field::id, seqan3::field::seq, seqan3::field::qual>{},
                                  std::ios_base::app};
  • It's annoying, but acceptable, that the fields have to be given.
Old

Example usage:

seqan3::sequence_file_output fout{"/tmp/test.sam",
                                  seqan3::fields<seqan3::field::id, seqan3::field::seq, seqan3::field::qual>{},
                                  {.append = true}};
  • It's annoying, but acceptable, that the fields have to be given.
  • I just reused sequence_file_output_options for this because I didn't want to add another enum/strong type. We could also do an enum or a bool. Or even a std::ios_base::openmode (with constraints?).
  • sequence_file_output_options::append is the only option that's fixed on construction
seqan3::sequence_file_output fout{"/tmp/test.sam",
                                  seqan3::fields<seqan3::field::id, seqan3::field::seq, seqan3::field::qual>{},
                                  {.append = true}};
fout.options.append = false; // No effect
seqan3::sequence_file_output fout{"/tmp/test.sam",
                                  seqan3::fields<seqan3::field::id, seqan3::field::seq, seqan3::field::qual>{}};
fout.options.append = true; // No effect

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels May 22, 2025
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (ca62168) to head (599f0f5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3365   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         270      270           
  Lines       11913    11913           
  Branches      103      103           
=======================================
  Hits        11689    11689           
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@seqan-actions seqan-actions added the lint [INTERNAL] signal for linting label May 22, 2025
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels May 22, 2025
@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants