Fix inconsistent variable naming and unused return value in allocat…

[c1lovez1]

…or - Fix variable name inconsistency in SWATokenToKVPoolAllocator.clear() (use is_not_in_free_group instead of is_in_free_group) - Remove unused sum_extend_lens from alloc_extend_kernel return value - Simplify return value handling to match alloc_decode_kernel pattern

Motivation

Modifications

Accuracy Test

Benchmark & Profiling

Checklist

• Format your code according to the Code Formatting with Pre-Commit.
• Add unit tests as outlined in the Running Unit Tests.
• Update documentation / docstrings / example tutorials as needed, according to Writing Documentation.
• Provide throughput / latency benchmark results and accuracy evaluation results as needed, according to Benchmark and Profiling and Accuracy Results.
• For reviewers: If you haven't made any contributions to this PR and are only assisting with merging the main branch, please remove yourself as a co-author when merging the PR.
• Please feel free to join our Slack channel at https://slack.sglang.ai to discuss your PR.

[gemini-code-assist]

Summary of Changes

Hello @c1lovez1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've addressed several code quality and efficiency improvements within the memory allocator. This includes fixing an inconsistent variable name in the SWATokenToKVPoolAllocator.clear() method, removing an unused return value from alloc_extend_kernel, and simplifying the corresponding return value handling in alloc_extend to align with the alloc_decode_kernel pattern.

Highlights

• Variable Renaming: Renamed is_in_free_group to is_not_in_free_group and adjusted its initial value in SWATokenToKVPoolAllocator.clear() for better clarity and consistency.
• Unused Return Value Removal: Eliminated the sum_extend_lens component from the return value of alloc_extend_kernel as it was not being utilized.
• Return Value Simplification: Updated alloc_extend to directly retrieve num_new_pages from the alloc_extend_kernel's return, streamlining the logic and matching existing patterns.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces several beneficial refactorings to python/sglang/srt/mem_cache/allocator.py. Key changes include correcting an inconsistent variable name in SWATokenToKVPoolAllocator.clear() for better consistency, and removing an unused return value from alloc_extend_kernel. Consequently, the return value handling in alloc_extend is simplified, aligning it with the pattern in alloc_decode_kernel. These modifications enhance code clarity and maintainability. The changes are well-implemented and I have no further comments.