CONSEL Optimizations #3
Open
+3,025
−1,910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to bring these enhancements to your attention to possibly implement them in the version that all researchers using this program are aware of. In short the enhancements include inside of the makermt.c/rand.c files: changing how random numbers are generated, and allowing scaleboot to be called on different threads in unison (using OpenMP). I believe these enhancements could greatly benefit the broader bioinformatics community.
As for the correctness of this new solution, I have been in contact with a professor at another University than mine who uses this program consistently, and the new output is up to his standards. Although I do not expect to whom this may concern to approve this without doing their own validation first. Please reach out to me at heinkale@ksu.edu or alexheinking71@gmail.com with any comments or concerns.