Skip to content

misc: upgrade to Kotlin 2.0.10 #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2024
Merged

misc: upgrade to Kotlin 2.0.10 #1137

merged 4 commits into from
Aug 7, 2024

Conversation

lauzadis
Copy link
Contributor

@lauzadis lauzadis commented Aug 6, 2024

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis requested a review from a team as a code owner August 6, 2024 13:58

This comment has been minimized.

Copy link
Contributor

@ianbotsf ianbotsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: Need to update the KOTLIN_COMPILER_VERSION constant as well. Or better yet, find a way to get rid of that duplicated version string somehow.

This comment has been minimized.

@lauzadis
Copy link
Contributor Author

lauzadis commented Aug 6, 2024

Or better yet, find a way to get rid of that duplicated version string somehow.

I don't think this is easily done, we have a separate TODO item to do a similar thing and I tried solving it and ran out of ideas

Copy link

github-actions bot commented Aug 6, 2024

Affected Artifacts

Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
test-suite-jvm.jar 97,844 97,907 -63 -0.06%
smithy-test-jvm.jar 62,946 63,071 -125 -0.20%

@lauzadis lauzadis merged commit 755d1c4 into main Aug 7, 2024
15 checks passed
@lauzadis lauzadis deleted the misc-upgrade-kotlin branch August 7, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants