Skip to content

misc: credentials search precedence change #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Conversation

0marperez
Copy link
Contributor

Issue #

Description of changes

-Adds provider name to IdentityProvider so IdentityProviderChain can give accurate exception messages when providers are wrapped

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@0marperez 0marperez added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Oct 11, 2024

This comment has been minimized.

1 similar comment

This comment has been minimized.

@0marperez 0marperez marked this pull request as ready for review October 11, 2024 16:08
@0marperez 0marperez requested a review from a team as a code owner October 11, 2024 16:08

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Nov 4, 2024

Affected Artifacts

Significantly increased in size

Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
aws-credentials-jvm.jar 24,061 22,796 1,265 5.55%
Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
http-client-jvm.jar 313,978 313,006 972 0.31%
runtime-core-jvm.jar 808,803 808,774 29 0.00%

@0marperez 0marperez changed the title misc: add provider name to identity provider misc: credentials search precedence change Nov 4, 2024
@0marperez 0marperez merged commit fa5fa01 into main Nov 4, 2024
20 of 21 checks passed
@0marperez 0marperez deleted the credentials-chain-order branch November 4, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-artifact-size-increase no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants