Fix JSON-RPC request parsing errors being ignored #2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosala
reviewed
Jun 6, 2025
wasm-node/javascript/test/misc.mjs
Outdated
| .then(async (chain) => { | ||
| const response = await chain.nextJsonRpcResponse(); | ||
| const parsed = JSON.parse(response); | ||
| if (parsed.id === null && parsed.error) |
There was a problem hiding this comment.
Actually, this shouldn't be null, right? It should be the id sent.
There was a problem hiding this comment.
Indeed. The tests take a very long time to run for me locally (several minutes), and I ran out of patience before it hit the new test.
There was a problem hiding this comment.
I understand the feeling, our zombienet tests have the same problem :)
|
Thanks for the prompt fix Pierre 🫶 |
josepot
approved these changes
Jun 6, 2025
|
Hey @tomaka! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2137
Work time: 45mn