Add authentication with username and password for phpredis RedisCluster #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi everyone, could someone review this PR (#733) when you have a moment? |
ostrolucky
added
feature
ostrolucky
approved these changes
Mar 16, 2025
|
Thanks @ostrolucky for merging this PR! 🎉 Do you know when the next release is scheduled? I’d like to know when I’ll be able to use this change. |
|
Actually I would appreciate if some people tested it first in a real project. You can use it if you specify dev-master in place of a version. I no longer use redis bundle in my projects. |
|
I've created a new tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Add authentication with username and password for phpredis RedisCluster
Description:
This pull request adds support for authentication with a username and password for
RedisClusterin phpredis. This allows the use of ACLs (Access Control Lists) as specified in the documentation.Changes:
PhpredisClientFactory.phpto support authentication forRedisClusterwith username and password.Please review the changes and provide feedback. Thank you!