feat: phpredis: add support for OPT_SCAN #745
Conversation
|
What about Predis? |
shakaran
changed the title
The original issue #608 was only mentioning phpredis. I just add predis support too. Let me know if it is ok. Thanks |
| $dsnOptions = array_merge($defaultOptions, $options, $dsnOptions); | ||
|
|
||
| if (isset($options['scan']) && $options['scan'] === 'prefix') { | ||
| $dsnOptions[Redis::OPT_SCAN] = Redis::SCAN_PREFIX; |
There was a problem hiding this comment.
This is overwritten by next instruction
There was a problem hiding this comment.
You are right, moved after parseDsn() so the options get merged. Resolved at 95f7e4e
| $dsnOptions = array_merge($defaultOptions, $options, $dsnOptions); | ||
|
|
||
| if (isset($options['scan']) && $options['scan'] === 'prefix') { | ||
| $dsnOptions[Redis::OPT_SCAN] = Redis::SCAN_PREFIX; |
There was a problem hiding this comment.
This class shouldn't use \Redis class, as that belongs to phpredis
There was a problem hiding this comment.
Resolved at 95f7e4e using class constants
ostrolucky
force-pushed
the
master
branch
3 times, most recently
from
37c8fe3 to
e049151
Compare
ostrolucky
force-pushed
the
feature/allow-opt-scan
branch
7 times, most recently
from
e8cae42 to
bda25c6
Compare
ostrolucky
changed the title
ostrolucky
changed the title
|
Sorry, in the end found this option is not relevant for predis so I've removed it. What was mistaking me was that there was never added support for |
ostrolucky
force-pushed
the
feature/allow-opt-scan
branch
3 times, most recently
from
457aea4 to
d2ba59a
Compare
ostrolucky
force-pushed
the
feature/allow-opt-scan
branch
from
d2ba59a to
dedf291
Compare
Fixes #608