A 'fix' for changing context on subsequent generations #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob7395
commented
Aug 29, 2024
| } | ||
|
|
||
| [Fact] | ||
| public void Generate_RulesSet_Should_Generate_Wtih_Ruleset_And_Oeverride() |
There was a problem hiding this comment.
This is just or my testing, not sure how to name a test that checks for this issue I would go with
Genrate_ShouldUserCorrectRuleset_WhenRulestChangesInSubsiquentCalles
But that is a different style
jacob7395
commented
Aug 29, 2024
| PrepareFinish(context); | ||
| CreateGenerateContext(ruleSets); | ||
|
|
||
| PrepareCreate(); |
There was a problem hiding this comment.
Could do both these methods as part of class construction since the context is no longer required.
jacob7395
changed the title
soenneker
dismissed
their stale review
Accidental approval, sorry, will get to this shortly
|
@soenneker no worries, it's more of a suggestion of how it could be fixed. I don't like how coupled it is to the underlying implementation of Bogus. If they alter how the count it indexed could brake in weirder ways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An draft PR with a possible solution to #261