Skip to content

feat(feature-toggle): add sequelize ORM #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions services/feature-toggle-service/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,21 @@ npm i @sourceloop/feature-toggle-service
- Start the application
`npm start`

### Using with Sequelize

This service supports Sequelize as the underlying ORM using [@loopback/sequelize](https://www.npmjs.com/package/@loopback/sequelize) extension. And in order to use it, you'll need to do following changes.

1. To use Sequelize in your application, add following to application.ts:

```ts
this.bind(FeatureToggleBindings.Config).to({
bindControllers: true,
useCustomSequence: false,
});
```

2. Use the `SequelizeDataSource` in your audit datasource as the parent class. Refer [this](https://www.npmjs.com/package/@loopback/sequelize#step-1-configure-datasource) for more.

### Asymmetric Token Signing and Verification

If you are using asymmetric token signing and verification, you need to create a datasource for auth database. Example datasource file for auth:-
Expand Down
3 changes: 3 additions & 0 deletions services/feature-toggle-service/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@
"typescript": "^5.4.5",
"widdershins": "^4.0.1"
},
"optionalDependencies": {
"@loopback/sequelize": "^0.6.9"
},
"peerDependencies": {
"db-migrate": "^1.0.0-beta.21",
"db-migrate-pg": "^1.3.0"
Expand Down
23 changes: 18 additions & 5 deletions services/feature-toggle-service/src/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ import {
FeatureValuesRepository,
StrategyRepository,
} from './repositories';
import {
FeatureRepository as FeatureSequelizeRepository,
FeatureValuesRepository as FeatureValuesSequelizeRepository,
StrategyRepository as StrategySequelizeRepository,
} from './repositories/sequelize';
import {IToggleServiceConfig} from './types';

export class FeatureToggleServiceComponent implements Component {
Expand Down Expand Up @@ -70,11 +75,19 @@ export class FeatureToggleServiceComponent implements Component {
// Mount default sequence if needed
this.setupSequence();
}
this.repositories = [
FeatureRepository,
FeatureValuesRepository,
StrategyRepository,
];
if (this.config?.useSequelize) {
this.repositories = [
FeatureSequelizeRepository,
FeatureValuesSequelizeRepository,
StrategySequelizeRepository,
];
} else {
this.repositories = [
FeatureRepository,
FeatureValuesRepository,
StrategyRepository,
];
}
this.models = [Feature, FeatureValues, Strategy];

this.controllers = [
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import {Getter, inject} from '@loopback/core';
import {IAuthUserWithPermissions} from '@sourceloop/core';
import {AuthenticationBindings} from 'loopback4-authentication';
import {FeatureValues} from '../../models';
import {FeatureToggleDbName} from '../../types';
import {SequelizeSoftCrudRepository} from 'loopback4-soft-delete/sequelize';
import {SequelizeDataSource} from '@loopback/sequelize';
export class FeatureValuesRepository extends SequelizeSoftCrudRepository<
FeatureValues,
typeof FeatureValues.prototype.id
> {
constructor(
@inject(`datasources.${FeatureToggleDbName}`)
dataSource: SequelizeDataSource,
@inject.getter(AuthenticationBindings.CURRENT_USER)
protected readonly getCurrentUser: Getter<
IAuthUserWithPermissions | undefined
>,
) {
super(FeatureValues, dataSource, getCurrentUser);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// Copyright (c) 2023 Sourcefuse Technologies
//
// This software is released under the MIT License.
// https://opensource.org/licenses/MIT
import {Getter, inject} from '@loopback/core';
import {IAuthUserWithPermissions} from '@sourceloop/core';
import {SequelizeSoftCrudRepository} from 'loopback4-soft-delete/sequelize';
import {SequelizeDataSource} from '@loopback/sequelize';
import {AuthenticationBindings} from 'loopback4-authentication';
import {Feature} from '../../models';
import {FeatureToggleDbName} from '../../types';

export class FeatureRepository extends SequelizeSoftCrudRepository<
Feature,
typeof Feature.prototype.name
> {
constructor(
@inject(`datasources.${FeatureToggleDbName}`)
dataSource: SequelizeDataSource,
@inject.getter(AuthenticationBindings.CURRENT_USER)
protected readonly getCurrentUser: Getter<
IAuthUserWithPermissions | undefined
>,
) {
super(Feature, dataSource, getCurrentUser);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// Copyright (c) 2023 Sourcefuse Technologies
//
// This software is released under the MIT License.
// https://opensource.org/licenses/MIT
export * from './feature-values.repository';
export * from './feature.repository';
export * from './strategy.repository';
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// Copyright (c) 2023 Sourcefuse Technologies
//
// This software is released under the MIT License.
// https://opensource.org/licenses/MIT
import {Getter, inject} from '@loopback/core';
import {IAuthUserWithPermissions} from '@sourceloop/core';
import {SequelizeSoftCrudRepository} from 'loopback4-soft-delete/sequelize';
import {SequelizeDataSource} from '@loopback/sequelize';
import {AuthenticationBindings} from 'loopback4-authentication';
import {Strategy} from '../../models';
import {FeatureToggleDbName} from '../../types';

export class StrategyRepository extends SequelizeSoftCrudRepository<
Strategy,
typeof Strategy.prototype.name
> {
constructor(
@inject(`datasources.${FeatureToggleDbName}`)
dataSource: SequelizeDataSource,
@inject.getter(AuthenticationBindings.CURRENT_USER)
protected readonly getCurrentUser: Getter<
IAuthUserWithPermissions | undefined
>,
) {
super(Strategy, dataSource, getCurrentUser);
}
}
Loading