refactor(chore): sonar issues fix #2313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhavbhalla2505
requested review from
Swati0077,
a team and
akshatdubeysf
as code owners
vaibhavbhalla2505
force-pushed
the
sonarfix
branch
3 times, most recently
from
ec656f6 to
b7a75d1
Compare
sonarfix
vaibhavbhalla2505
force-pushed
the
sonarfix
branch
from
b7a75d1 to
17df414
Compare
a-ganguly
reviewed
Aug 8, 2025
| @@ -434,12 +434,27 @@ export abstract class SearchQueryBuilder<T extends Model> { | |||
|
|
|||
| return val; | |||
| } | |||
| private isDateType(type: PropertyType): boolean { | |||
|
|
|||
| isStringTyoe( | |||
There was a problem hiding this comment.
check the name of the function.
isStringTyoe is not correct
this should be isStringType
a-ganguly
reviewed
Aug 8, 2025
| return ( | ||
| type === Date || (typeof type === 'function' && type.name === 'Timestamp') | ||
| ); | ||
| } | ||
|
|
||
| isNumberType( |
There was a problem hiding this comment.
what are the reason for adding these functions
There was a problem hiding this comment.
to reduce the complexity of "toColumnValue" function
sonarfix
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sonar issues fix
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: