Skip to content

Allow the components of an AsyncEvent to be correlated in reductions #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Minimaximize
Copy link
Contributor

Added an Id to allow the components of an AsyncEvent (started, resolved, rejected) to be correlated in event reductions.

This is important in cases where an asyncEvent is passed a new promise before the previous promise has resolved or rejected; as the subsequent resolution or rejection of the previous promise may cause undesirable state changes

Added an Id to allow the components of an AsyncEvent (started, resolved, rejected)
to be correlated in event reductions.

This is important in cases where an asyncEvent is passed a new promise before
the previous promise has resolved or rejected; as the subsequent
resolution or rejection of the previous promise may cause undesirable state changes
@soxtoby
Copy link
Owner

soxtoby commented Jul 4, 2023

What does this let you do that you couldn't already do with the context?

@Minimaximize
Copy link
Contributor Author

Not a lot, it's essentially just a basic context that isn't required to be passed in with the promise.
It was mostly to fix a bug in LoadState where the previous event rejecting caused it to appear loaded before the latest event had completed

@soxtoby
Copy link
Owner

soxtoby commented Jul 4, 2023

Seems like something to fix in user space then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants