Fix Cube Fit component initialization #3727
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
added
bug
rosteen
force-pushed
the
fix-cube-component-initialization
branch
from
1ec3cc1 to
5c8a415
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (85.71%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3727 +/- ##
=======================================
Coverage 86.28% 86.28%
=======================================
Files 177 177
Lines 23922 23928 +6
=======================================
+ Hits 20640 20647 +7
+ Misses 3282 3281 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rosteen
requested review from
javerbukh,
kecnry,
bmorris3,
haticekaratay,
cshanahan1,
gibsongreen and
MatthewPortman
as code owners
|
The coverage missing in template_mixin.py is getting flagged because I changed a string there, I'm not going to worry about covering that code for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes initializing a model component when a spectral subset is selected and Cube Fit is toggled on (specifically with a cube with spectral axis index of 0). I also took the opportunity to avoid sending data through the glue-astronomy translators just to get a subset mask and instead use the Glue
to_maskmethod on the data object itself.I'll try to add some coverage before merging, opening as draft to see if the tests pass here before I mark ready for review.