Skip to content

Conversation

bjoernsteinhagen
Copy link
Contributor

@bjoernsteinhagen bjoernsteinhagen commented Aug 10, 2025

Description

Integrates analysis results extraction with UI settings system. Users can now select result types through the connector interface, replacing hard-coded extraction logic.

Relates to CNX-2239

User Value

Users can dynamically choose which analysis result types to extract without code changes.

Changes:

  • Added CsiResultsExtractorFactory for dynamic extractor resolution
  • Updated IApplicationResultsExtractor with TargetObjectType property
  • Integrated ResultTypeSetting with extractor factory
  • Modified CsiRootObjectBuilder to use factory-based extraction loop
  • Connected UI settings to converter settings pipeline

Validation of changes:

Result type selection now flows from UI dropdown through settings manager to extractor factory, enabling dynamic result extraction based on user selection.

Checklist:

  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

Copy link

linear bot commented Aug 10, 2025

Copy link

codecov bot commented Aug 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (bjorn/properties-curation-structural-connectors-analysis-results@4387872). Learn more about missing BASE report.

Additional details and impacted files
@@                                         Coverage Diff                                         @@
##             bjorn/properties-curation-structural-connectors-analysis-results    #1025   +/-   ##
===================================================================================================
  Coverage                                                                    ?   41.20%           
===================================================================================================
  Files                                                                       ?      109           
  Lines                                                                       ?     3080           
  Branches                                                                    ?      293           
===================================================================================================
  Hits                                                                        ?     1269           
  Misses                                                                      ?     1765           
  Partials                                                                    ?       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bjoernsteinhagen bjoernsteinhagen merged commit 880d777 into bjorn/properties-curation-structural-connectors-analysis-results Aug 10, 2025
5 checks passed
@bjoernsteinhagen bjoernsteinhagen deleted the bjorn/cnx-2239-integrate-results-type-dropdown-to-extractor branch August 10, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant