feat(rhino): add category mapping query methods for revit mapper #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## bjorn/cnx-2192-create-a-mapperlayer-filter #1030 +/- ##
===========================================================================
Coverage 41.20% 41.20%
===========================================================================
Files 109 109
Lines 3080 3080
Branches 293 293
===========================================================================
Hits 1269 1269
Misses 1765 1765
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oguzhankoral
approved these changes
Aug 15, 2025
oguzhankoral
merged commit 2318d51
into
bjorn/cnx-2192-create-a-mapperlayer-filter
5 checks passed
oguzhankoral
deleted the
bjorn/cnx-2301-populate-applied-mapping-in-dropdown-for-selected-object
branch
bjoernsteinhagen
added a commit
that referenced
this pull request
Aug 15, 2025
* feat: Add layer mapping support and rename object mapping methods * feat: object-layer mapping detection for UI updates * feat: add layer hierarchy mapping resolution * refactor: unused methods * feat: layer dropdown * feat(rhino): add effective object resolution for layer mappings * fix: event handling * feat: generic model, duhh * refactor: move records to mapper namespace * refactor: consolidate Rhino layer and object utilities into helpers * refactor: move `GetEffectiveObjectsForLayerMapping` to `RevitMappingResolver` * chore: update category list (#1028) * fix: `ModifyAttributes` for object mapping changes * fix: lol no need for static * refactor: DI for helper class * refactor: hardcoded list in dui * fix: updating mapped layers * fix: handle object addition events to update mappings on copy * feat: poc (#1030) * fix: no static!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added methods to query existing category mappings for objects and layers, enabling the frontend to display current mapping state in the dropdown.
User Value
Users can now see what category mappings are already applied to their selected objects/layers. See specklesystems/speckle-connectors-dui#48.
Changes:
GetCategoryMappingsForObjects()method to return a set (i.e. unique list) of categories for given object IDsGetCategoryMappingsForLayers()method to return distinct categories for given layer IDsValidation of changes:
validation-of-changes.mp4