Skip to content

[ENH] spm-runtime dependency #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 20, 2025
Merged

[ENH] spm-runtime dependency #48

merged 18 commits into from
Jun 20, 2025

Conversation

balbasty
Copy link
Contributor

@balbasty balbasty mentioned this pull request Jun 19, 2025
@balbasty
Copy link
Contributor Author

balbasty commented Jun 19, 2025

Tests now pass on github (I had to explicitely install the dev branch of mpython-core, this should be removed before merging).

@balbasty balbasty requested a review from johmedr June 19, 2025 16:24
Copy link
Collaborator

@johmedr johmedr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for integrating the spm-runtime dependency @balbasty !

@johmedr
Copy link
Collaborator

johmedr commented Jun 20, 2025

Tests now pass on github (I had to explicitely install the dev branch of mpython-core, this should be removed before merging).

I think this can now be removed. In addition, we can increase the version number in the PR to avoid any conflict.

@johmedr johmedr merged commit c9525c0 into main Jun 20, 2025
32 checks passed
@johmedr johmedr deleted the dep-runtime branch June 23, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants