Skip to content

Readd an Ant example that uses Ivy and a scriptselector as replacement for the removed custom selector #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025

Conversation

Vampire
Copy link
Member

@Vampire Vampire commented Apr 19, 2025

No description provided.

@Vampire Vampire force-pushed the vampire/ant-example branch from e3c37dd to d1af330 Compare April 19, 2025 21:23
@Vampire Vampire force-pushed the vampire/ant-example branch from d1af330 to ea74dd1 Compare April 19, 2025 21:27
@leonard84
Copy link
Member

Who still uses ANT in this day and age?

@leonard84 leonard84 requested a review from Copilot April 20, 2025 14:33
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reintroduces an Ant example that leverages Ivy and a scriptselector as a replacement for a removed custom selector.

  • Adds a new GitHub Actions job named "check-ant" to run Ant tests.
  • Configures Java 8 and caches Ivy dependencies for improved build consistency.
Files not reviewed (3)
  • build.xml: Language not supported
  • ivy.xml: Language not supported
  • ivysettings.xml: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/main.yml:66

  • [nitpick] The step name 'Check Spock' is misleading in the context of an Ant test run. Consider renaming it to 'Run Ant Test' to better reflect its functionality.
- name: 'Check Spock'

@Vampire
Copy link
Member Author

Vampire commented Apr 20, 2025

Who still uses ANT in this day and age?

Me, why not?
Especially if you have an Ant build that works perfectly fine since decades and that you only need to run occasionally, there is not too much reason to migrate it to something different.

And in one of those I just wanted to add Spock and wished we'd have a proper Ant example in the example project.
Besides that the user manual still claims it does have an Ant example.

Why not readd an Ant example, it does not really cost anything and it is beneficial for those still wanting or needing it.
Especially with the scriptselector.

Comment on lines +173 to +174
import org.spockframework.buildsupport.SpecClassFileFinder
self.selected = new SpecClassFileFinder().isRunnableSpec(file)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a single line

Suggested change
import org.spockframework.buildsupport.SpecClassFileFinder
self.selected = new SpecClassFileFinder().isRunnableSpec(file)
self.selected = new org.spockframework.buildsupport.SpecClassFileFinder().isRunnableSpec(file)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No specific reason, just two shorter lines instead of one long line.
If you want one long line instead, I'll change it.

@leonard84 leonard84 merged commit 963fd34 into master Apr 20, 2025
3 checks passed
@leonard84 leonard84 deleted the vampire/ant-example branch April 20, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants