[WIP TC]: Tool call impl #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PolarishT <zhangzhenting@corp.netease.com>
Signed-off-by: PolarishT <zhangzhenting@corp.netease.com>
Signed-off-by: PolarishT <zhangzhenting@corp.netease.com>
yuluo-yx
reviewed
Mar 6, 2025
...e/backend/src/main/java/com/alibaba/cloud/ai/application/SpringAIIntegrationApplication.java
Outdated
Show resolved
Hide resolved
yuluo-yx
reviewed
Mar 6, 2025
yuluo-yx
reviewed
Mar 6, 2025
yuluo-yx
reviewed
Mar 6, 2025
...backend/src/main/java/com/alibaba/cloud/ai/application/controller/SAAFunctionController.java
Outdated
Show resolved
Hide resolved
yuluo-yx
reviewed
Mar 6, 2025
There was a problem hiding this comment.
这个 .keep 不要删，是为了保持这个文件夹，github 默认不会保存空的文件夹再 github
There was a problem hiding this comment.
学到了，我以为是我使用的XcodeMap引入的奇奇怪怪的东西
yuluo-yx
reviewed
Mar 6, 2025
yuluo-yx
reviewed
Mar 7, 2025
| </dependencies> | ||
|
|
||
| <build> | ||
| <finalName>app.jar</finalName> |
yuluo-yx
reviewed
Mar 7, 2025
| @@ -35,8 +48,38 @@ public class SAAFunctionController { | |||
|
|
|||
| private final SAAFunctionService functionService; | |||
|
|
|||
| public SAAFunctionController(SAAFunctionService functionService) { | |||
| private final SAABaseService baseService; | |||
There was a problem hiding this comment.
注入这个似乎用不到？注入 function service 就好了
yuluo-yx
reviewed
Mar 7, 2025
| @UserIp | ||
| @GetMapping("tool-call") | ||
| @Operation(summary = "DashScope ToolCall Chat") | ||
| public Flux<Result<String>> chat( |
There was a problem hiding this comment.
这里改成 Flux 就好了，Result jianyi 不好解析
yuluo-yx
reviewed
Mar 7, 2025
|
|
||
| this.defaultChatClient = | ||
| ChatClient.builder(new DashScopeChatModel(new DashScopeApi(System.getenv( |
There was a problem hiding this comment.
这里为啥要这样写哇？chatmodel autoconfiguration 会自己注入的，你这是用 ai 写的吗？ai 的代码质量堪忧哇
There was a problem hiding this comment.
我自己写的哇
我习惯这样写了 哈哈哈哈
yuluo-yx
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?