Move database TLS disable config to general kolla config

[seunghun1ee]

These two Kolla config options need to be in general one to actually have an effect on customer systems.

[gemini-code-assist]

Summary of Changes

Hello @seunghun1ee, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to correctly apply database TLS disable configurations by moving them from a CI-specific Kolla configuration file to a more general Kolla configuration file. This ensures that the settings, which are a temporary workaround for a known ProxySQL bug, take effect on customer systems as intended.

Highlights

• Configuration Relocation: The database_enable_tls_internal and database_enable_tls_backend settings have been relocated from etc/kayobe/environments/ci-multinode/kolla/globals.yml to etc/kayobe/kolla/globals.yml.
• Impact on Customer Systems: This change ensures that the database TLS disable configuration is applied to customer systems, addressing the stated purpose of the pull request.
• ProxySQL Bug Workaround: The moved configuration now includes a note indicating that these settings are a temporary measure to disable database TLS due to a known bug in ProxySQL 2.7 (issue #4877).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request moves the configuration to disable database TLS from an environment-specific file to the global Kolla configuration. This is a workaround for a bug in ProxySQL. While the change is logical, I've suggested an improvement to make this workaround easily overridable by operators. This enhances maintainability and provides better control over this security-sensitive setting. Disabling database TLS globally has security implications, and making it configurable allows sites not affected by the bug to easily re-enable it.