fix: make col_sample min equals to 1 #385
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved Column Sampling for Small Datasets
In our current implementation,
col_sampleis treated as a percentage. When the number of columns is small andcol_sampleis also small, calculating the sampled columns with:can result in
col_sizebeing 0.For example:
if there are 4 columns and
col_sample = 0.1, thenint(0.1 * 4)yields 0, which subsequently causes an error during model generation due to having 0 input features.This pull request updates the logic to ensure that at least one column is always selected when
col_sampleis positive by using:This change prevents errors in cases with a small number of features, improving the robustness of the model creation process.